Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network watcher #329

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Fix network watcher #329

merged 1 commit into from
Nov 30, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Rework start code for UdpClient to allow several instances listening on the same port.
  • Rework listener thread to allow graceful stopping.

Motivation and Context

  • Allow several instances listening on the same port. Required for multiple VS instances running.
  • Stopping the watcher was causing exceptions and/or causing the socket to actually remain opened.

How Has This Been Tested?

  • VS experimental instance.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Rework start code for UdpClient to allow several instances listening on the same port.
- Rework listener thread to allow graceful stopping.
@josesimoes josesimoes merged commit c8f90f6 into develop Nov 30, 2021
@josesimoes josesimoes deleted the fix-listener branch November 30, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants